fix: -string->double for cljs shouldn't allow trailing garbage #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opqdonut
force-pushed
the
fix-js-double-decode
branch
from
1c80a4a
to
912223a
Compare
(js/parseFloat "1.2abba") ==> 1.2 This was a difference between clj and cljs behaviour, but didn't have a test. Potentially a breaking change since somebody could've unknowingly relied on this.
opqdonut
force-pushed
the
fix-js-double-decode
branch
from
912223a
to
cf7d1f5
Compare
opqdonut
commented
Sep 1, 2023
src/malli/transform.cljc
Outdated
| @@ -69,7 +69,7 @@ | |||
| (defn -string->double [x] | |||
| (if (string? x) | |||
| (try #?(:clj (Double/parseDouble x) | |||
| :cljs (let [x' (js/parseFloat x)] (if (js/isNaN x') x x'))) | |||
| :cljs (let [x' (js/Number x)] (if (js/isNaN x') x x'))) | |||
There was a problem hiding this comment.
or should we use cljs.core/parse-double & clojure.core/parse-double?
There was a problem hiding this comment.
added a commit that switches to parse-double. note that parse-double was introduced recently in clojure(script) 1.11
ikitommi
approved these changes
Sep 1, 2023
|
Merging this despite the 1.10 vs 1.11 question. Tests don't pass currently on 1.10 anyway, see #943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(js/parseFloat "1.2abba") ==> 1.2
This was a difference between clj and cljs behaviour, but didn't have
a test.
Potentially a breaking change since somebody could've unknowingly
relied on this.